feat: add an attribute denylist for autocapture #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daibhin
approved these changes
Sep 15, 2023
|
Size Change: +448 B (0%) Total Size: 685 kB
ℹ️ View Unchanged
|
benjackwhite
approved these changes
Sep 15, 2023
src/types.ts
Outdated
| * Exclude certain element attributes from autocapture | ||
| * E.g. ['aria-label'] or [data-attr-pii] | ||
| */ | ||
| element_attribute_denylist?: string[] |
There was a problem hiding this comment.
ignorelist sounds so much closer to what it actually is but deny fits with the existing naming so 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen instances where an element attribute is used to store complex data which can break autocapture parsing.
While it's better to fix those instances, let's also provide our users with an escape hatch,